Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up v3 branch #529

Merged
merged 8 commits into from
Jun 16, 2021
Merged

Up v3 branch #529

merged 8 commits into from
Jun 16, 2021

Conversation

joehoyle
Copy link
Member

No description provided.

@joehoyle joehoyle requested a review from roborourke June 16, 2021 10:21
@joehoyle
Copy link
Member Author

I don't understand git well enough to know why we are seeing the diff for the Command fix, when it's in 6660495

roborourke
roborourke approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is weird. Maybe your local copy of the v3-branch wasn't up to date at the time?

@joehoyle
Copy link
Member Author

I just opened the PR in GitHub 🤷

@joehoyle joehoyle merged commit d47a596 into v3-branch Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborourke roborourke roborourke approved these changes

@hm-linter hm-linter[bot] hm-linter[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joehoyle @roborourke @iamlili