Properly manage default on chain storage version for pallets added after genesis #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylavrenov
force-pushed
the
fix-storage-version
branch
2 times, most recently
from
73e6114 to
b2fb581
Compare
MOZGIII
approved these changes
Oct 26, 2024
dmitrylavrenov
force-pushed
the
fix-storage-version
branch
from
25c0f19 to
6ce1c41
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Add UpgradeInit for pallet-balanced.. at runtime * Implement init storage version logic * Apply InitStorageVersion at humanode-runtime * Improve log messages * Improve info message for init storage version logic Co-authored-by: MOZGIII <[email protected]> * Remove unused log * Some renaming * Revert "Properly manage default on chain storage version for pallets added after genesis (#1305)" This reverts commit ca44d00. --------- Co-authored-by: MOZGIII <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
humanode-networkdevelopment there are some pallets that were added after genesis to our runtime containing initialStorageVersion = 1:pallet-balanced-currency-swap-bridges-initializer- Implement bridges pot currency swap accounts inititialization #716pallet-dummy-precompiles-code- Dummy contract code for EVM precompiles #777During work on #940 the following changes have been acknowledged in substrate codebase - paritytech/substrate@9957da3. So, the following errors have been faced during
try-runtimechecks:The root cause has been discovered - paritytech/substrate#14641. Unfortunately, we should manually fix current storage versions in next runtime update.