Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Interop-4844] Data gas accounting #4998

Merged
merged 27 commits into from
Jan 25, 2023
Merged

[Interop-4844] Data gas accounting #4998

merged 27 commits into from
Jan 25, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jan 24, 2023

PR description

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

shemnon and others added 27 commits January 23, 2023 07:01
@shemnon
Don't cache protocol spec in block creator (hyperledger#4982)
9034d31 
* Don't cache protocol spec in block creator

Don't cache the protocol spec in the block creator.  With the new
shanghaiTimestamp the correct spec may be a function of the timestamp
not just the block number.  So every time we are asked to build a block
re-query the spec.

Signed-off-by: Danno Ferrin <[email protected]>
@jflo
KZG point eval precompile (hyperledger#4860)
f8a0f87 
* KZG implementation

Signed-off-by: Justin Florentine <[email protected]>
@garyschulte
address case of block values exceeding long (hyperledger#4983)
48702aa 
* address case of block values exceeding long

Signed-off-by: garyschulte <[email protected]>
@siladu
Improve MainnetBlockBodyValidator logging (hyperledger#4984)
844db62 
Associate block number and hash with the various invalid block warnings

Print a less obscure message when there's no error message.

Signed-off-by: Simon Dudley <[email protected]>
@macfarla
[MINOR] move Clique tests to junit5 (hyperledger#4975)
1a39e38 
* easy ones

* parameterized test

* refactor to avoid unnecessary stubbings

* migrate abstract class and subclasses to junit 5

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla
[MINOR] javadoc for kzg precompile (hyperledger#4988)
7d04ed2 
* javadoc for kzg precompile

Signed-off-by: Sally MacFarlane <[email protected]>
@fab-10
Add max_fee_per_data_gas field to transaction (hyperledger#4970)
617c14a 
Signed-off-by: Fabio Di Fabio <[email protected]>
@shemnon
RJumpV overflow (hyperledger#4985)
6021474 
Address an RJumpV overflow discovered by reference tests.

Signed-off-by: Danno Ferrin <[email protected]>
@fab-10
Gas accounting for EIP-4844
8e43731 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Update CHANGELOG
05f4387 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Fix tests
7a94b4a 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Merge branch 'main' into 4844-gas-accounting
642c26f
@jframe
Fix create block using wrong protocol schedule when parent is genesis (…
ab42080 
…hyperledger#4986)

Signed-off-by: Jason Frame <[email protected]>
@fab-10
Remove duplicated code
18ef1be 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Fix blob tx identification
080ead0 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Merge branch 'main' into 4844-gas-accounting
52c00f9
@fab-10
Update log
55b1f7a 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Add reference to the EIP-4844
657f975 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Fix and improvements from code review
0a0c702 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Move Cancun fee market constants into Cancun class
ffb6c93 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Code reorg
72c6988 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Track max data gas per block using GasLimitCalculator
6c575ec 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Use long internally to represent data gas
1699663 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Fix javadoc
af7c70a 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Write power of 2 in a self documenting way
79e9338 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10
Merge branch '4844-gas-accounting' into eip-4844-interop
ffcb43d 
# Conflicts:
#	CHANGELOG.md
#	ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLDataFetchers.java
#	ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
#	ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
#	ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
#	ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/TransactionInvalidReason.java
#	gradle/verification-metadata.xml
#	gradle/versions.gradle
#	plugin-api/build.gradle
@fab-10
Replace inline constants
86598fb 
Signed-off-by: Fabio Di Fabio <[email protected]>
@fab-10 fab-10 changed the title Data gas accounting [Interop-4844] Data gas accounting Jan 25, 2023
garyschulte
garyschulte approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@garyschulte garyschulte merged commit 949e3fe into hyperledger:eip-4844-interop Jan 25, 2023
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
34d92d3 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
3cb6eb6 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
85a96b3 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
61d1503 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
7a62d7b 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
2453768 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
4d11fe7 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
ec6fe63 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
52a073c 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jflo pushed a commit that referenced this pull request Jun 30, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
7b6345c 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
82b8219 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
41254ea 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
b9419f9 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
37ef7cb 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
80abf31 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
43ebaeb 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
cf13bb9 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
371b6c9 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
1184d86 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jflo pushed a commit that referenced this pull request Jul 5, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (#4998)
a4bcbda 
merge of #4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
2134e95 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
93a7ae6 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
efa11ef 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
d673791 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
a067375 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
49e952e 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
ace4f92 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
c15befb 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
fe5c499 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
jflo pushed a commit to jflo/besu that referenced this pull request Jul 20, 2023
@fab-10 @jflo
[Interop-4844] Data gas accounting (hyperledger#4998)
f2c2efa 
merge of hyperledger#4992 into interop feature branch

Signed-off-by: Fabio Di Fabio <[email protected]>
(cherry picked from commit 949e3fe)
(cherry picked from commit 9734c983ce00bda161434506688f12ee07bbd820)
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fab-10 @garyschulte @shemnon @jflo @siladu @macfarla @jframe