Fix toSlatePoint()
when text node ends in \n
in Firefox
#4547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Firefox, selecting the entire contents of a document via Ctrl+A causes the editor to crash when the document ends with a
\n
character.Refer to the issue below for more specific replication steps.
Issue
Fixes: #4373
Example
Before
Before.-.Firefox.Ctrl+A.newline.bug.mp4
After
After.-.Firefox.Ctrl+A.newline.bug.mp4
Context
In Firefox,
range.cloneContents()
returns an extra trailing\n
, when the document ends with a new-line character. This results in the offset length being off by one, so we need to subtract one to account for this.Chrome:
Firefox
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)