Only apply Firefox toSlatePoint()
offset fix when the cloned contents end in \n\n
#4552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up on #4547.
Context
I meant to update the PR to only apply the offset fix when the cloned textContent ends in
\n\n
instead of\n
but didn't get a chance to push that up before it was merged.The rationale for this change is that we only need to apply this fix for the specific edge-case where Firefox returns
\n\n
for thetextContent
of the cloned range.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)