Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply Firefox toSlatePoint() offset fix when the cloned contents end in \n\n #4552

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

clauderic
Copy link
Collaborator

@clauderic clauderic commented Sep 27, 2021

Description
This PR follows up on #4547.

Context
I meant to update the PR to only apply the offset fix when the cloned textContent ends in \n\n instead of \n but didn't get a chance to push that up before it was merged.

The rationale for this change is that we only need to apply this fix for the specific edge-case where Firefox returns \n\n for the textContent of the cloned range.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@clauderic clauderic self-assigned this Sep 27, 2021
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2021

🦋 Changeset detected

Latest commit: 1469fbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@clauderic clauderic requested a review from dylans September 27, 2021 16:39
@dylans dylans merged commit 37d60c5 into ianstormtaylor:main Sep 27, 2021
@github-actions github-actions bot mentioned this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants