fix: change session print loop to block until all events are handled

changelog.md

@@ -30,6 +30,7 @@
 - Seal the capability keeper in the `app.go` template
 - Change faucet to allow C.O.R.S. preflight requests.
 - Fix config file migration to void leaving end of file content chunks
+- Change session print loop to block until all events are handled.
 - Handle "No records were found in keyring" message when checking keys.
 
 ### Features

ignite/pkg/cliui/cliui.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"sync"
 
 	"github.com/manifoldco/promptui"
 
@@ -29,6 +30,7 @@ type Session struct {
 	ev      events.Bus
 	spinner *clispinner.Spinner
 	out     uilog.Output
+	wg      *sync.WaitGroup
 }
 
 // Option configures session options.
@@ -73,6 +75,7 @@ func StartSpinner() Option {
 func New(options ...Option) Session {
 	session := Session{
 		ev: events.NewBus(),
+		wg: &sync.WaitGroup{},
 		options: sessionOptions{
 			stdin:  os.Stdin,
 			stdout: os.Stdout,
@@ -99,7 +102,10 @@ func New(options ...Option) Session {
 		session.spinner = clispinner.New(clispinner.WithWriter(session.out.Stdout()))
 	}
 
-	go session.handleEvents()
+	// The main loop that prints the events uses a wait group to block
+	// the session end until all the events are printed.
+	session.wg.Add(1)
+	go session.handleEvents(session.wg)
 
 	return session
 }
@@ -215,9 +221,12 @@ func (s Session) PrintTable(header []string, entries ...[]string) error {
 func (s Session) End() {
 	s.StopSpinner()
 	s.ev.Stop()
+	s.wg.Wait()
 }
 
-func (s Session) handleEvents() {
+func (s Session) handleEvents(wg *sync.WaitGroup) {
+	defer wg.Done()
+
 	stdout := s.out.Stdout()
 
 	for e := range s.ev.Events() {
@@ -227,7 +236,7 @@ func (s Session) handleEvents() {
 		case events.IndicationFinish:
 			s.StopSpinner()
 			fmt.Fprintf(stdout, "%s\n", e)
-		case events.IndicationNone:
+		default:
 			resume := s.PauseSpinner()
 			fmt.Fprintf(stdout, "%s\n", e)
 			resume()

ignite/services/network/publish.go

@@ -307,11 +307,11 @@ func (n Network) sendAccountRequest(
 	}
 
 	if requestRes.AutoApproved {
-		n.ev.Send("Account added to the network by the coordinator!", events.ProgressStarted())
+		n.ev.Send("Account added to the network by the coordinator!", events.ProgressFinished())
 	} else {
 		n.ev.Send(
 			fmt.Sprintf("Request %d to add account to the network has been submitted!", requestRes.RequestID),
-			events.ProgressStarted(),
+			events.ProgressFinished(),
 		)
 	}
 	return nil