fix: change session print loop to block until all events are handled

[jeronimoalbi]

Fixes #2917

[lumtis]

Thanks for having fixed this so quickly
The main issue with ProgressFinished is fixed

ignite n chain join 24 --amount 95000000stake
? Peer's address 200.46.122.3:26656
Source code fetched
Blockchain set up
Account added to the network by the coordinator!
Validator added to the network by the coordinator!

There are still some inconsistency in some output using event bus like:

ignite n validator show spn1daefnhnupn85e8vv0yc5epmnkcr5epkqncn2le
◢ Fetching validator description identity: "0xaaa"
details: foo foo fii fii
website: haha.com
security: haha

Event printed from ProgressStarted is not erased. I'm trying to see the difference with the logic of ignite n chain list where this issue doesn't occur but can't find any difference

[jeronimoalbi]

I believe it has something to do with how the spinner works. I think that the text is only deleted when it's the spinner text setted by calling session.StartSpinner("TEXT"). Event messages are deleted only when using the events.ProgressStarted() option.

Actually I want to explore how to improve the session/events API. I didn't move far away from the initial PR, but I think there is room for improvements.

[tbruyelle]

I checked and I think I found the cause of the problem: session is duplicated. The one used in the events loop is not the same as the one returned by clui.New(). Thus, the unerlying spinner is also different, when the event loop affects a new one on IndicationStart, session.Println() still has a nil spinner and so the pause has no effect.

A simple fix is to return a pointer in clui.New() and use pointer receiver method for all methods that affects the session.

[lumtis]

I checked and I think I found the cause of the problem: session is duplicated. The one used in the events loop is not the same as the one returned by clui.New(). Thus, the unerlying spinner is also different, when the event loop affects a new one on IndicationStart, session.Println() still has a nil spinner and so the pause has no effect.

A simple fix is to return a pointer in clui.New() and use pointer receiver method for all methods that affects the session.

Thank you for looking at this. I will check that.

Can be handled in another PR