fix(network): spinner issue for validator and coordinator commands
#2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
ilgooz,
jeronimoalbi,
aljo242,
tbruyelle and
fadeev
as code owners
|
I think the fix should go to |
tbruyelle
reviewed
Oct 18, 2022
We can still merge this one as a quick fix |
jeronimoalbi
previously approved these changes
Oct 18, 2022
aljo242
reviewed
Oct 18, 2022
tbruyelle
previously approved these changes
Oct 18, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…gnite#2939) * fix 1 * fix 2 * format * remove unnecessary * imports Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cliui.StartSpinner()tocliui.NewThis fix the issue highlighted here: #2920 (comment)
If the option is not provided,
spinnerin thesessionobject of the high level method will be nil and therefore will not stop the spinner used in the inside methods.I'm wondering if this is not a misconception of
cliui, should I open an issue for this?