refactor: remove consumer chain scaffolding #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
github-actions
bot
added
component:ci
salmad3
approved these changes
Aug 9, 2024
ilgooz
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to integrate v0.52 (#4289), we should remove the consumer chain scaffolding form Ignite 29.
The consumer chain scaffolding was anyway going to be removed in favor of ignite/apps#101.
This deletes all the scaffolding logic, except the
IsConsumerChainfrom the config. We need this to stay in ignite as it skips some initialization logic (that should be done via the app)