refactor: remove consumer chain scaffolding

changelog.md

@@ -38,6 +38,7 @@
 - [#4160](https://github.com/ignite/cli/pull/4160) Enable copyloopvar linter
 - [#4162](https://github.com/ignite/cli/pull/4162) Enable errcheck linter
 - [#4189](https://github.com/ignite/cli/pull/4189) Deprecate `ignite node` for `ignite connect` app
+- [#4290](https://github.com/ignite/cli/pull/4290) Remove ignite consumer from ignite cli (this functionality will be in the `consumer` app)
 
 ### Fixes
 

ignite/cmd/scaffold_chain.go

@@ -16,7 +16,6 @@
 	flagMinimal         = "minimal"
 	flagNoDefaultModule = "no-module"
 	flagSkipGit         = "skip-git"
-	flagIsConsumer      = "consumer"
 
 	tplScaffoldChainSuccess = `
 ⭐️ Successfully created a new blockchain '%[1]v'.
@@ -88,11 +87,10 @@
 	c.Flags().Bool(flagSkipGit, false, "skip Git repository initialization")
 	c.Flags().Bool(flagSkipProto, false, "skip proto generation")
 	c.Flags().Bool(flagMinimal, false, "create a minimal blockchain (with the minimum required Cosmos SDK modules)")
-	c.Flags().Bool(flagIsConsumer, false, "scafffold an ICS consumer chain")
 	c.Flags().String(flagProtoDir, defaults.ProtoDir, "chain proto directory")
 
-	// Cannot have both minimal and consumer flag
-	c.MarkFlagsMutuallyExclusive(flagIsConsumer, flagMinimal)
+	// consumer scaffolding have been migrated to an ignite app
+	c.Flags().MarkDeprecated("consumer", "use 'ignite consumer' app instead")
 
 	return c
 }
@@ -109,7 +107,6 @@
 		noDefaultModule, _ = cmd.Flags().GetBool(flagNoDefaultModule)
 		skipGit, _         = cmd.Flags().GetBool(flagSkipGit)
 		minimal, _         = cmd.Flags().GetBool(flagMinimal)
-		isConsumer, _      = cmd.Flags().GetBool(flagIsConsumer)
 		params, _          = cmd.Flags().GetStringSlice(flagParams)
 		moduleConfigs, _   = cmd.Flags().GetStringSlice(flagModuleConfigs)
 		skipProto, _       = cmd.Flags().GetBool(flagSkipProto)
@@ -139,7 +136,6 @@
 		protoDir,
 		noDefaultModule,
 		minimal,
-		isConsumer,
 		params,
 		moduleConfigs,
 	)

ignite/config/chain/base/config.go

@@ -127,6 +127,7 @@ const (
 	ValidationSovereign = "sovereign"
 	// ValidationConsumer is when the chain is validated by a provider chain.
 	// Such chain is called a consumer chain.
+	// This is a special case for ICS chains, used by the consumer ignite app (https://github.com/ignite/apps/issues/101).
 	ValidationConsumer = "consumer"
 )
 

ignite/services/chain/init.go

@@ -9,7 +9,6 @@
 	"github.com/imdario/mergo"
 
 	chainconfig "github.com/ignite/cli/v29/ignite/config/chain"
-	plugininternal "github.com/ignite/cli/v29/ignite/internal/plugin"
 	chaincmdrunner "github.com/ignite/cli/v29/ignite/pkg/chaincmd/runner"
 	"github.com/ignite/cli/v29/ignite/pkg/cliui/view/accountview"
 	"github.com/ignite/cli/v29/ignite/pkg/confile"
@@ -176,11 +175,9 @@
 		return nil
 	}
 	if cfg.IsConsumerChain() {
-		err := plugininternal.ConsumerWriteGenesis(ctx, c)
-		if err != nil {
-			return err
-		}
+		// we skip early if the chain is a consumer chain
+		return nil
 	} else {
 		// Sovereign chain writes validators in gentxs.
 		_, err := c.IssueGentx(ctx, createValidatorFromConfig(cfg))
 		if err != nil {
@@ -216,12 +213,14 @@
 	if err != nil {
 		return false, err
 	}
+
 	cfg, err := c.Config()
 	if err != nil {
 		return false, err
 	}
 	if cfg.IsConsumerChain() {
-		return plugininternal.ConsumerIsInitialized(context.Background(), c)
+		// when consumer chain, we skip the IsInialized logic
+		return true, nil
 	}
 
 	gentxDir := filepath.Join(home, "config", "gentx")

ignite/services/scaffolder/init.go

@@ -21,7 +21,7 @@ func Init(
 	ctx context.Context,
 	runner *xgenny.Runner,
 	root, name, addressPrefix, protoDir string,
-	noDefaultModule, minimal, isConsumerChain bool,
+	noDefaultModule, minimal bool,
 	params, moduleConfigs []string,
 ) (string, string, error) {
 	pathInfo, err := gomodulepath.Parse(name)
@@ -60,7 +60,6 @@ func Init(
 		path,
 		noDefaultModule,
 		minimal,
-		isConsumerChain,
 		params,
 		moduleConfigs,
 	)
@@ -75,7 +74,7 @@ func generate(
 	addressPrefix,
 	protoDir,
 	absRoot string,
-	noDefaultModule, minimal, isConsumerChain bool,
+	noDefaultModule, minimal bool,
 	params, moduleConfigs []string,
 ) (xgenny.SourceModification, error) {
 	// Parse params with the associated type
@@ -106,7 +105,6 @@ func generate(
 		BinaryNamePrefix: pathInfo.Root,
 		AddressPrefix:    addressPrefix,
 		IsChainMinimal:   minimal,
-		IsConsumerChain:  isConsumerChain,
 	})
 	if err != nil {
 		return xgenny.SourceModification{}, err

ignite/templates/app/app.go

@@ -19,9 +19,6 @@ var (
 
 	//go:embed files-minimal/* files-minimal/**/*
 	filesMinimal embed.FS
-
-	//go:embed files-consumer/* files-consumer/**/*
-	filesConsumer embed.FS
 )
 
 const (
@@ -46,9 +43,6 @@ func NewGenerator(opts *Options) (*genny.Generator, error) {
 		excludePrefix = append(excludePrefix, ibcConfig)
 		overridesFS["files-minimal"] = filesMinimal
 	}
-	if opts.IsConsumerChain {
-		overridesFS["files-consumer"] = filesConsumer
-	}
 
 	g := genny.New()
 	if err := g.SelectiveFS(subfs, includePrefix, nil, excludePrefix, nil); err != nil {
@@ -74,7 +68,6 @@ func NewGenerator(opts *Options) (*genny.Generator, error) {
 	ctx.Set("GitHubPath", opts.GitHubPath)
 	ctx.Set("BinaryNamePrefix", opts.BinaryNamePrefix)
 	ctx.Set("AddressPrefix", opts.AddressPrefix)
-	ctx.Set("IsConsumerChain", opts.IsConsumerChain)
 	ctx.Set("DepTools", cosmosgen.DepTools())
 	ctx.Set("IsChainMinimal", opts.IsChainMinimal)