This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Make timeout optional property #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalters512
reviewed
Jan 22, 2019
There was a problem hiding this comment.
I don't particularly like this because timeout is in fact a required property for the underlying Transition. I still want people to get prop type failures in development mode, even if they won't be validated in a production environment. I don't know that there's a particularly elegant solution to this; maybe something like
timeout: (props, ...args) => {
let pt = timeoutsShape
if (pt) {
pt = pt.isRequired
return pt(props, ...args)
}
}
nwalters512
reviewed
Jan 22, 2019
src/PageTransition.js
Outdated
| @@ -268,9 +268,10 @@ PageTransition.propTypes = { | |||
|
|
|||
| PageTransition.defaultProps = { | |||
| loadingComponent: null, | |||
| loadingCallbackName: 'pageTransitionReadyToEnter', | |||
| loadingCallbackName: 'pagesTransitionReadyToEnter', | |||
There was a problem hiding this comment.
Why was this prop name changed?
There was a problem hiding this comment.
Sorry, this is typo, will fix it soon
|
@nwalters512 This is the same solution for react-transition-group, I agree with you. |
property
izaccavalheiro
approved these changes
Jan 26, 2019
euharrison
reviewed
Jan 28, 2019
Co-Authored-By: teleginzhenya <[email protected]>
|
Closing in favor of #21 - thanks for your work on this though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17 and vercel/next.js#6086