This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Fix issue with Node production environment and react-transition-group's PropTypes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`react-transition-group`'s custom PropTypes are null if the NODE_ENV is "production." This causes an Internal Server Error in Next.js, "Cannot read property 'isRequired' of null." To fix this, I simply mirrored the react-transition-group's code by nullifying the prop type `timeoutsShape` only if `process.env.NODE_ENV` is "production".
I realized my previous commit fixed the problem but would have resulted in a console.error in production for any time that a `loadingTimeout` prop was supplied.
ScottMorse
changed the title
|
Please merge this |
nwalters512
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
It seems to be six to one, half dozen to the other with this and #18, but given that that one still has issues to be resolved and that this one more closely matches what react-transition-group is already doing, I'll go ahead and merge this. Thanks for the contribution!
There are some lingering prettier/linter concerns here, but that's half on me for not getting CI set up on this repo yet. I'll resolve all of that later 👍
|
Glad to help! Love the package by the way. It makes Next.js so much more awesome. Makes route changes feel like a native app. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix to a known issue, described below.
react-transition-group's custom PropTypes are set to null if the Node env is set to "production." This causes an Internal Server Error in Next.js, "Cannot read property 'isRequired' of null."
To fix this, I simply mirrored the react-transition-group's code by nullifying the prop type
timeoutsShapeonly ifprocess.env.NODE_ENVis"production".With this fix, the PropType will still be applied in development and create the appropriate console errors.