fix: ensure fit parameter will respect overriding value, fixes #268 (…

…#311)

package.json

@@ -5,7 +5,8 @@
   "author": "Frederick Fogerty <[email protected]> (https://github.com/frederickfogerty)",
   "contributors": [
     "Frederick Fogerty <[email protected]> (https://github.com/frederickfogerty)",
-    "Max Kolyanov (https://github.com/maxkolyanov)"
+    "Max Kolyanov (https://github.com/maxkolyanov)",
+    "Sherwin Heydarbeygi <[email protected]> (https://github.com/sherwinski)" 
   ],
   "license": "ISC",
   "bugs": {

src/react-imgix-bg.jsx

@@ -84,11 +84,11 @@ const BackgroundImpl = props => {
 
   const renderedSrc = (() => {
     const srcOptions = {
+      fit: "crop",
       ...imgixParams,
       ...(disableLibraryParam ? {} : { ixlib: `react-${PACKAGE_VERSION}` }),
       width,
       height,
-      fit: "crop",
       dpr
     };
 

test/integration/react-imgix.test.jsx

@@ -559,6 +559,30 @@ describe("Background Mode", () => {
     expect(ref instanceof HTMLElement).toBe(true);
     expect(findURIfromSUT(sut).getQueryParamValue("w")).toBe("100");
   });
+  it("the fit parameter defaults to 'crop'", async () => {
+    const sut = await renderBGAndWaitUntilLoaded(
+      <div>
+        <Background src={src} className="bg-img">
+          <div>Content</div>
+        </Background>
+      </div>
+    );
+
+    const bgImageSrcURL = findURIfromSUT(sut);
+    expect(bgImageSrcURL.getQueryParamValue("fit")).toBe("crop");
+  });
+  it("the fit parameter can be overriden", async () => {
+    const sut = await renderBGAndWaitUntilLoaded(
+      <div>
+        <Background src={src} className="bg-img" imgixParams={{ fit: "clip" }}>
+          <div>Content</div>
+        </Background>
+      </div>
+    );
+
+    const bgImageSrcURL = findURIfromSUT(sut);
+    expect(bgImageSrcURL.getQueryParamValue("fit")).toBe("clip");
+  });
 });
 
 function injectScript(src) {