Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background doesn't support changing fit #268

Closed
verbeeksteven opened this issue Jan 24, 2019 · 0 comments · Fixed by #330
Closed

Background doesn't support changing fit #268

verbeeksteven opened this issue Jan 24, 2019 · 0 comments · Fixed by #330
Labels
Priority: Medium Type: Bug

Comments

@verbeeksteven
Copy link

Describe the bug
Setting a imgixParams fit to anything but crop has no effect. It still is set to crop as the fit is hardcoded. It should be able to be override by passing a imgixParams fit value.

To Reproduce
https://codesandbox.io/s/540nzkv4qn

Steps to reproduce the behaviour:

  1. Create a new Background element
  2. Set imgixParams.fit to anything but crop
  3. See URL has fit=crop

Expected behaviour
Fit should change depending what is set in imgixParams

Information:

  • react-imgix version: latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): 8.6.0 imgix/react-imgix
2 participants
@sherwinski @verbeeksteven