fix: ensure fit parameter will respect overriding value fixes #268 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
force-pushed
the
fit-param-override
branch
from
7d5a17f to
3d74496
Compare
|
Looks good to me 👍 |
jayeb
approved these changes
Mar 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any attempt to override the
fitparameter when using aBackgroundcomponent will have no effect. Example + steps to reproduce can be found in #268.Big thanks to @verbeeksteven for catching this and getting the ball rolling with #270.
Bug Fix
fix(<area>): fixed bug #issue-numberSteps to Test
Can be found under
test/integration/react-imgix.test.jsx