feat: use exponential increase for srcset widths #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
reviewed
Nov 19, 2018
|
@jayeb seems like the tests have passed - is this good to go? |
|
Ah, I saw something about tests in the description and assumed there would be tests coming to cover the new behavior. Could we get some? |
|
Similar to the comment over on imgix.js (imgix/imgix.js#130), not sure what tests I can add which don't over-specify on the implementation. |
…om/imgix/react-imgix into fred/use-exponential-srcset-widths * 'fred/use-exponential-srcset-widths' of https://github.com/imgix/react-imgix: chore(deps): update dependency webpack to v4.26.0 (#226) chore(deps): update react monorepo to v16.6.3 (#223) chore(deps): update dependency prettier to v1.15.2 (#222)
|
Hey @jayeb I've added some more tests as discussed offline - can you have a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the srcset width-generation logic. The widths now grow exponentially, rather than by a fixed amount. This means that the dimensions of a rendered image are at most 8% from the "pixel-perfect" dimensions.
Fixes #227
Steps to test
Ensure that tests still pass.