Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v1.16.0 #571

Merged
merged 23 commits into from
Sep 23, 2016
Merged

release v1.16.0 #571

merged 23 commits into from
Sep 23, 2016

Conversation

benmosher
Copy link
Member

@benmosher benmosher commented Sep 22, 2016 •
edited
Loading

  • get once-over from @jfmengels
  • tag
  • publish
  • merge to release
  • merge to master

grahamb and others added 22 commits August 29, 2016 10:58
@grahamb
Support webpack configs that export a function
896f984 
Webpack 2 supports webpack configuration files that export a function (see https://webpack.github.io/docs/roadmap.html). This commit adds support for this by testing if the `require`ed config is a function, and if so, executing it.
@ljharb
[New] extensions: accept both a string, and an object to override it.
daf38ac 
Fixes #390.
@benmosher
Merge remote-tracking branch 'grahamb/allow-webpack-func' (#533)
320d5d7
@benmosher
resolvers/webpack/v0.6.0
d7ac357
@benmosher
use "files" instead of .npmignore
ee49b74
@greenkeeperio-bot @benmosher
chore(package): update typescript-eslint-parser to version 0.3.0 (#559)
01f1852 
https://greenkeeper.io/
@tristanbbq @benmosher
#527: Correct docs for rule no-extraneous-dependencies (#560)
c07c057
@preco21
Update obsoleted reference
49cf441
@benmosher
rebound links + corrected ES7
935f8a9
@benmosher
Merge pull request #561 from preco21/patch-1
32b5494 
docs: Update obsoleted reference
@spalger @benmosher
Implement new rule: no-internal-modules (#485)
c57beae 
* Implement new rule: no-reaching-inside

* normalize path segments all path segments to '/'

* point to minimatch/glob docs to define glob syntax

* refactor no-reaching-inside, allow now points to importable modules/files

* add test to verify that "no-reaching/allow" can limit the depth of matches

* code style improvements

* rename to no-internal-modules

* remove extra test executor
@benmosher
changelog note for #485
2b471c7
@benmosher
updated resolvers/node/package.json to use "files" (fixes #531)
e087ec4
@ljharb
Cache extension settings using has.
f507ff3
@greenkeeperio-bot @benmosher
chore(package): update nyc to version 8.3.0 (#562)
515d159 
https://greenkeeper.io/
@jfmengels @benmosher
Fix #564: Fix tests not running due to Espree bump (#565)
12bf6da 
* Fix #564: Fix tests not running due to Espree bump

* updated malformed test

also, the most trivial of line formatting changes
@benmosher
Merge remote-tracking branch 'ljharb/extensions_options' (#555)
c45fdc3
@benmosher
Fix #566: reject false positive on export default from '...'
b6ac532
@benmosher
Fix #545: allow re-export of defaults from ignored files (i.e. node_m…
24c04b7 
…odules)
@benmosher
changelog note for #545
0f527d2
@jfmengels @benmosher
Add no-dynamic-require rule (fixes #567) (#568)
2524c09
@benmosher
bump to v1.16.0
2946d4b
@benmosher benmosher added this to the 1.16.0 milestone Sep 22, 2016
@coveralls
Copy link

coveralls commented Sep 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 97.861% when pulling 2946d4b on v1.16.0-release into 2e4e449 on release.

@jfmengels
Copy link
Collaborator

I have some fixes for the changelog (mostly my fault, and then some cleanup). Shall I just push them on this branch directly?

@benmosher
Copy link
Member Author

Yep, that makes sense to me, I normally do cleanup on the prerelease branch since it all gets merged back to master at the end.

@jfmengels
Copy link
Collaborator

jfmengels commented Sep 22, 2016 •
edited
Loading

Ok, pushed.

benmosher
benmosher commented Sep 22, 2016
View reviewed changes
CHANGELOG.md
@@ -8,15 +8,13 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel

## [1.16.0] - 2016-09-22
### Added
- New rule [`no-dynamic-require`]: restrict deep package imports to specific folders. ([#567])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I didn't see this at all

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, me neither. I knew it was weird that I didn't get any comment, I always mess up somewhere. Out of the 75+ rules I wrote, there's not even a handful that were merged without a comment :p

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests looked great and the changelog note existed. that's basically my rubric 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha 😄
Honestly, I would write so many more rules if I didn't have to write docs. That's pretty much a pain/time waster everytime (as I'm more fluent in code than docs). If only I had a scribe that wrote the docs for me...)
In https://github.com/jfmengels/eslint-plugin-fp/, I at least automatised updating the index.js and the README, so that solves part of my problems ^^

@jfmengels
Copy link
Collaborator

After this, I propose to stop working on v1 from now on (or really soon), start merging v2, fix the remaining stuff (like adapting the new rules to the new format) and do the remaining breaking changes.

What do you think?

@coveralls
Copy link

coveralls commented Sep 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 97.861% when pulling af062f1 on v1.16.0-release into 2e4e449 on release.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 97.861% when pulling af062f1 on v1.16.0-release into 2e4e449 on release.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 97.861% when pulling af062f1 on v1.16.0-release into 2e4e449 on release.

@benmosher
Copy link
Member Author

That's more or less been my goal since v2 branched. 😅

I figure the best way to make it real is to get a beta out and start using it, just haven't had the time and I've been letting these tactical releases push it back. (which I think has made sense, practically, but it'd be nice to get v2 launched)

also, ps: I ran the eslint-transforms tool for the new rule format on v2 branch, so that should be good to go.

@benmosher
Copy link
Member Author

or merge v2 to master, I guess. then PRs/forks won't be based on v1

@benmosher
Copy link
Member Author

ah, yes, as you had already said:

start merging v2

I need to read more sequentially 😅

@jfmengels
Copy link
Collaborator

Yeah, let's merge v2 into master. Hopefully the existing PRs won't have to rebase, but small price to pay otherwise. When that's done, we'll be kind of pushed to release v2 before any new minor releases :)

I ran the eslint-transforms tool for the new rule format on v2 branch

Ah cool, didn't even know that one existed. Or actually... I did but just forgot about it. I did mine by hand (which was okay time-wise). We'll have to re-do on the new rules included in this release I think.

@benmosher
Copy link
Member Author

It's easy to re-run, I think it's just a no-op if it's done

@benmosher benmosher merged commit 2d26d34 into release Sep 23, 2016
@benmosher benmosher deleted the v1.16.0-release branch September 23, 2016 11:07
@Saroni11 Saroni11 mentioned this pull request Jul 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfmengels jfmengels jfmengels approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@benmosher @coveralls @jfmengels @grahamb @ljharb @greenkeeperio-bot @tristanbbq @preco21 @spalger