Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate npm package name to @improbable-eng/grpc-web #289

Closed
5 tasks done
jonnyreeves opened this issue Dec 13, 2018 · 11 comments
Closed
5 tasks done

Migrate npm package name to @improbable-eng/grpc-web #289

jonnyreeves opened this issue Dec 13, 2018 · 11 comments

Comments

@jonnyreeves
Copy link
Contributor

jonnyreeves commented Dec 13, 2018

Overview

To disambiguate the two, I propose that we migrate this project to publish under the @improbable-eng namespace in npm, ie: @improbable-eng/grpc-web, making use the npm orgs feature.

Migration Path

Consumers would need to modify their import statements accordingly:

# Before
import { grpc } from 'grpc-web-client'

# After
import { grpc } from '@improbable-eng/grpc-web'

cc @easyCZ @johanbrandhorst @MarcusLongmuir

@jonny-improbable
Copy link
Contributor

To get the ball rolling I've secured the improbable-eng org on npm

@jonny-improbable
Copy link
Contributor

Step one complete, published 0.8.0 of @improbable-eng/grpc-web to npm

johanbrandhorst added a commit to johanbrandhorst/grpc.github.io that referenced this issue Jan 11, 2019
Improbable has decided to disambiguate its client
from the official one by using the organisation name,
see improbable-eng/grpc-web#289.
@johanbrandhorst
Copy link
Contributor

Something that hasn't been mentioned, we need to change the import in the generated files to point to the new package.

@johanbrandhorst
Copy link
Contributor

johanbrandhorst added a commit to johanbrandhorst/ts-protoc-gen that referenced this issue Jan 12, 2019
johanbrandhorst added a commit to johanbrandhorst/ts-protoc-gen that referenced this issue Jan 12, 2019
jonny-improbable pushed a commit to improbable-eng/ts-protoc-gen that referenced this issue Jan 12, 2019
@jonnyreeves jonnyreeves changed the title RFC: Migrate npm package name Migrate npm package name to @improbable-eng/grpc-web Jan 12, 2019
@jonnyreeves
Copy link
Contributor Author

ts-protoc-gen v0.9.0 has been released which code-gens import statements that use the @improbable-eng/grpc-web package.

@jonny-improbable
Copy link
Contributor

jonny$ npm i grpc-web-node-http-transport
npm WARN deprecated [email protected]: This package has been deprecated in favor of @improbable-eng/grpc-web-node-http-transport

@jonny-improbable
Copy link
Contributor

OK, I've also deprecated the grpc-web-client package, and it's showing up on npm but not when I install it locally... 🤷‍♂️

Still, pretty sure we can now mark this migration as complete; I'll leave this issue open for a week to provide visibility to the community should anyone run into problems.

@johanbrandhorst
Copy link
Contributor

So, uh, we've release 0.8.0 on NPM but we haven't got a corresponding release of this repo yet. How did we get out of sync like this? Can I make a release?

@johanbrandhorst
Copy link
Contributor

Bump

@jonny-improbable
Copy link
Contributor

This has been done for a long time 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants