-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate npm package name to @improbable-eng/grpc-web #289
Comments
To get the ball rolling I've secured the |
Step one complete, published 0.8.0 of @improbable-eng/grpc-web to npm |
Improbable has decided to disambiguate its client from the official one by using the organisation name, see improbable-eng/grpc-web#289.
Something that hasn't been mentioned, we need to change the import in the generated files to point to the new package. |
ts-protoc-gen v0.9.0 has been released which code-gens import statements that use the |
|
OK, I've also deprecated the Still, pretty sure we can now mark this migration as complete; I'll leave this issue open for a week to provide visibility to the community should anyone run into problems. |
So, uh, we've release 0.8.0 on NPM but we haven't got a corresponding release of this repo yet. How did we get out of sync like this? Can I make a release? |
Bump |
This has been done for a long time 🥂 |
Overview
grpc-web
grpc-web-client
To disambiguate the two, I propose that we migrate this project to publish under the
@improbable-eng
namespace in npm, ie:@improbable-eng/grpc-web
, making use the npm orgs feature.Migration Path
@improbable-eng/grpc-web
on npm (Scope and renamegrpc-web-client
package #290)grpc-web-client
package (Update all child packages to reference @improbable-eng/grpc-web #297)@improbable-eng/grpc-web
(Point to new version of npm package ts-protoc-gen#147)grpc-web-client
andgrpc-web-node-http-transport
packages with a note that encourages consumers to switch to@improbable-eng
versionsConsumers would need to modify their import statements accordingly:
cc @easyCZ @johanbrandhorst @MarcusLongmuir
The text was updated successfully, but these errors were encountered: