Update all child packages to reference @improbable-eng/grpc-web #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -251,7 +251,7 @@ proto.improbable.grpcweb.test.PingRequest.prototype.getValue = function() { | |||
|
|
|||
| /** @param {string} value */ | |||
| proto.improbable.grpcweb.test.PingRequest.prototype.setValue = function(value) { | |||
| jspb.Message.setField(this, 1, value); | |||
| jspb.Message.setProto3StringField(this, 1, value); | |||
There was a problem hiding this comment.
Hmm no sure why these changes have crept in, let me check my local env.
There was a problem hiding this comment.
Aha, I'm rocking libprotoc 3.6.1 locally whereas our config uses 2.5.0
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "grpc-web-ci", | |||
| "private": true, | |||
There was a problem hiding this comment.
Unrelated, but the root package should never be published as it just contains metadata for the monorepo.
jonny-improbable
force-pushed
the
feature/update-child-packages
branch
3 times, most recently
from
ed7e1d8 to
7e31f74
Compare
jonny-improbable
force-pushed
the
feature/update-child-packages
branch
from
7e31f74 to
70fea5c
Compare
johanbrandhorst
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #289; this PR aims to remove all references to the
grpc-web-clientpackage from the monorepo.