Skip to content

Commit

Permalink
Transport member of ServiceClientOptions should be optional (#125)
Browse files Browse the repository at this point in the history
* Transport member of ServiceClientOptions should be optional

* Update examples
  • Loading branch information
virtuald authored and jonnyreeves committed Oct 16, 2018
1 parent 7846e2f commit 51f57ea
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/generated/proto/orphan_pb_service.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/service/grpcweb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function generateTypescriptDefinition(fileDescriptor: FileDescriptorProto, expor

printer.printLn(`export type ServiceError = { message: string, code: number; metadata: grpc.Metadata }`);
printer.printLn(`export type Status = { details: string, code: number; metadata: grpc.Metadata }`);
printer.printLn(`export type ServiceClientOptions = { transport: grpc.TransportConstructor; debug?: boolean }`);
printer.printLn(`export type ServiceClientOptions = { transport?: grpc.TransportConstructor; debug?: boolean }`);
printer.printEmptyLn();
printer.printLn("interface UnaryResponse {");
printer.printIndentedLn("cancel(): void;");
Expand Down

0 comments on commit 51f57ea

Please sign in to comment.