Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport member of ServiceClientOptions should be optional #125

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

virtuald
Copy link
Contributor

What the title says. Should be good, given that clients are initialized with...

function BookServiceClient(serviceHost, options) {
  this.serviceHost = serviceHost;
  this.options = options || {};
}

@jonnyreeves
Copy link
Contributor

Thanks for contributing @virtuald! I'm happy to approve this change, but you also need to re-generate the example code. You can achieve this by invoking ./generate.sh.

The fact that CI passes implies that we are missing an automated check to ensure that the example code is in sync; I'll add a task to track this improvement.

@jonny-improbable
Copy link
Contributor

Same as #124, @virtuald could you please rebase your changes against the latest master, this should highlight the discrepancy with the generated code being out of sync.

@jonnyreeves jonnyreeves merged commit 51f57ea into improbable-eng:master Oct 16, 2018
@virtuald virtuald deleted the transport-option branch October 17, 2018 03:17
coltonmorris pushed a commit to coltonmorris/ts-protoc-gen that referenced this pull request Oct 17, 2018
* upstream/master:
  Transport member of ServiceClientOptions should be optional (improbable-eng#125)
  Allow canceling unary calls (improbable-eng#124)
  CI should check that generated code has been committed (improbable-eng#127)
  Bumped to v0.7.8-pre (improbable-eng#123)
  Prepare 0.7.7 release (improbable-eng#112)
  Clean up Bazel Installation during Travis Build (improbable-eng#122)
  Don't deploy .deb files to npm (improbable-eng#121)
  Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118)
  Make ServiceError optionally null (improbable-eng#116)
  Be explicit about the need for a CommonJS environment. (improbable-eng#108)
  Replace usage of `Object.assign` (improbable-eng#110)
  Add hint for Windows users (improbable-eng#107)
  Collapse Bazel Instructions in README (improbable-eng#106)
  Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82)
  Add support for jstype annotation (improbable-eng#104)
chrisgervang pushed a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 14, 2018
…le-eng#125)

* Transport member of ServiceClientOptions should be optional

* Update examples
chrisgervang added a commit to chrisgervang/flowtype-protoc-gen that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants