Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should check that generated code has been committed #126

Closed
jonnyreeves opened this issue Oct 16, 2018 · 1 comment
Closed

CI should check that generated code has been committed #126

jonnyreeves opened this issue Oct 16, 2018 · 1 comment
Labels
pinned

Comments

@jonnyreeves
Copy link
Contributor

#125 passed CI but the generated code checked into the repo is out of sync with what ts-protoc-gen woult output with the changes.

We should add a CI step to ensure that the generated code remains in sync.
@jonny-improbable
Copy link
Contributor

Resolved by #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnyreeves @jonny-improbable