CI should check that generated code has been committed #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a travis build step which re-generates the generated code and then checks for changes to the workspce. If any are detected it will fail the build and prompt the user to run the `./generate.sh` script.
|
Pretty sure we are seeing these errors because it's the first time this script has been executed on Travis. I'll try switching to using unzip instead of tar |
easyCZ
reviewed
Oct 16, 2018
| ./generate.sh | ||
| MODIFIED_FILES=$(git diff --name-only) | ||
| if [[ -n $MODIFIED_FILES ]]; then | ||
| echo "ERROR: Changes detected in generated code, please run './generate.sh' and check-in the changes." |
There was a problem hiding this comment.
This will unfortunately NOT be invisible to our users and hence they won't be able to self-fix this. Not sure if we have a fix for this. We could make the project visible but not modifiable to the public?
easyCZ
approved these changes
Oct 16, 2018
coltonmorris
pushed a commit
to coltonmorris/ts-protoc-gen
that referenced
this pull request
Oct 17, 2018
* upstream/master: Transport member of ServiceClientOptions should be optional (improbable-eng#125) Allow canceling unary calls (improbable-eng#124) CI should check that generated code has been committed (improbable-eng#127) Bumped to v0.7.8-pre (improbable-eng#123) Prepare 0.7.7 release (improbable-eng#112) Clean up Bazel Installation during Travis Build (improbable-eng#122) Don't deploy .deb files to npm (improbable-eng#121) Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118) Make ServiceError optionally null (improbable-eng#116) Be explicit about the need for a CommonJS environment. (improbable-eng#108) Replace usage of `Object.assign` (improbable-eng#110) Add hint for Windows users (improbable-eng#107) Collapse Bazel Instructions in README (improbable-eng#106) Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82) Add support for jstype annotation (improbable-eng#104)
chrisgervang
pushed a commit
to chrisgervang/flowtype-protoc-gen
that referenced
this pull request
Nov 14, 2018
…g#127) * CI should check that generated code has been committed Add a travis build step which re-generates the generated code and then checks for changes to the workspce. If any are detected it will fail the build and prompt the user to run the `./generate.sh` script. * Patch up generation script so it can be invoked from another script. * Use unzip instead of tar.
chrisgervang
added a commit
to chrisgervang/flowtype-protoc-gen
that referenced
this pull request
Nov 16, 2018
…bable-eng#127)" This reverts commit f60b1b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a travis build step which re-generates the generated code and then checks for changes to the workspce. If any are detected it will fail the build and prompt the user to run the
./generate.shscript.