Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.71 #3689

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Update MSRV to 1.71 #3689

merged 3 commits into from
Nov 7, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Nov 7, 2023

Closes: #3688

Description

Using Rust v1.70 to build Hermes will generate the following error:

cargo build --release --bin hermes
error: failed to select a version for `ibc-proto`.
    ... required by package `ibc-relayer v0.26.0`
versions that meet the requirements `^0.38.0` (locked to 0.38.0) are: 0.38.0

the package `ibc-relayer` depends on `ibc-proto`, with features: `tonic` but `ibc-proto` does not have these features.
 It has an optional dependency with that name, but that dependency uses the "dep:" syntax in the features table, so it does not have an implicit feature with that name.


failed to select a version for `ibc-proto` which could resolve this conflict

This has been fixed in Rust v1.71.0 with rust-lang/cargo#12130


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from romac November 7, 2023 11:06
@ljoss17 ljoss17 merged commit 7e357a9 into master Nov 7, 2023
42 checks passed
@ljoss17 ljoss17 deleted the luca_joss/update-msrv branch November 7, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump MSRV to 1.71
2 participants