Fix dep/feat syntax with hidden implicit optional dependencies #12130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-dependency-resolution
epage
reviewed
May 12, 2023
epage
approved these changes
May 12, 2023
There was a problem hiding this comment.
Based on the tests this seems fine but I don't feel the resolver changes are clear enough without digging a lot more into the implementation for me to feel comfortable merging this. The change causes us to skip some parts but its not obvious from this that this allows the rest to work
weihanglo
approved these changes
May 12, 2023
Co-authored-by: Weihang Lo <[email protected]>
|
@bors r=weihanglo |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2023
Update cargo 8 commits in 13413c64ff88dd6c2824e9eb9374fc5f10895d28..09276c703a473ab33daaeb94917232e80eefd628 2023-05-10 13:46:18 +0000 to 2023-05-16 21:43:35 +0000 - docs: Clarify that crates.io doesn't link to docs.rs right away. (rust-lang/cargo#12146) - docs(ref): Clarify MSRV is generally minor (rust-lang/cargo#12122) - Fix `check_for_file_and_add`'s check for conflict file (rust-lang/cargo#12135) - Fixes: Incorrect document link (rust-lang/cargo#12143) - doc: intra-doc links and doc comments for build script (rust-lang/cargo#12133) - Add Cargo team charter. (rust-lang/cargo#12010) - Remove useless drop of copy type (rust-lang/cargo#12136) - Fix dep/feat syntax with hidden implicit optional dependencies (rust-lang/cargo#12130) r? ghost
This was referenced Nov 6, 2023
ydirson
added a commit
to ydirson/xen-guest-agent
that referenced
this pull request
Feb 2, 2024
…is set The syntax used was equivalent to "dep:xenstore-rs/static", and a bug in Rust 1.70 (fixed by rust-lang/cargo#12130 in 1.71) was triggered.
ydirson
added a commit
to ydirson/xen-guest-agent
that referenced
this pull request
Feb 2, 2024
Our dependency `env_logger` suffers from a bug in versions of Cargo older than 1.71, fixed by rust-lang/cargo#12130 (the one we suffered from before the "Cargo: don't let feature "static" pull xenstore-rs unless "xenstore" is set" fix). Note that some of our dependencies already required 1.70 or later. Signed-off-by: Yann Dirson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
dep/featsyntax in the[features]table where it wouldn't work if the optional dependency had its implicit feature removed via thedep:syntax.The problem is that both resolvers were expecting that
dep/featwould be able to activate a feature named "dep". But if that implicit feature wasn't created, then it would fail with an error.This was just an oversight (which probably happened in #9574).
Fixes #10788