forked from jamesblasco/modal_bottom_sheet
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from jamesblasco:main #1
Open
pull
wants to merge
29
commits into
innFactory:main
Choose a base branch
from
jamesblasco:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: deprecate duplicated name * fix: support flutter 3.7 * feat: add pre release version
* 🐛 (Annotated region) Move annatated region in _CupertinoBottomSheetContainer and made overlayStyle depend on transitionBackgroundColor luminance * 🐛 (OverlayStyle) remove computed overlayStyle in showCupertinoModalBottomSheet function
Tries to mirror changes made in flutter/flutter PR 126535 for devicePixelRatio Does not mirror changes made to scroll_position.dart @OverRide double get devicePixelRatio => context.devicePixelRatio;
Co-authored-by: Remon Helmond <[email protected]>
Fixes: #228
* feat: sheet improvements * fix: remove unused simulation * fix: rebase * fix: update dependencies
This PR flutter/flutter#137304 makes SemanticsNode.isMergedIntoParent readonly, which makes the customized scrollable.dart incompatible.
* chore: Upgrade compileSdkVersion, targeSdkVersion and kotlinVersion * chore: Upgrade gradle version * chore: Fix incompatibility with Java 16
* fix: lints * feat: fix inner not resizing * fix: expanded
* feat: release * feat: add changelog
…e` (#434) * Fix the system UI overlay style in the `CupertinoModalBottomSheetRoute` * Fix background color * Reduce rebuilds --------- Co-authored-by: Jonas Wanke <[email protected]>
Bumps [mocktail](https://github.com/felangel/mocktail) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/felangel/mocktail/releases) - [Commits](felangel/mocktail@mocktail-v1.0.3...mocktail-v1.0.4) --- updated-dependencies: - dependency-name: mocktail dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [meta](https://github.com/dart-lang/sdk/tree/main/pkg) from 1.11.0 to 1.12.0. - [Changelog](https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md) - [Commits](https://github.com/dart-lang/sdk/commits/1.12.0/pkg) --- updated-dependencies: - dependency-name: meta dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lints](https://github.com/dart-lang/lints) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/dart-lang/lints/releases) - [Changelog](https://github.com/dart-lang/lints/blob/main/CHANGELOG.md) - [Commits](dart-lang/lints@v3.0.0...v4.0.0) --- updated-dependencies: - dependency-name: lints dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [lints](https://github.com/dart-lang/lints) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/dart-lang/lints/releases) - [Changelog](https://github.com/dart-lang/lints/blob/main/CHANGELOG.md) - [Commits](dart-lang/lints@v3.0.0...v4.0.0) --- updated-dependencies: - dependency-name: lints dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… true (#411) * include resizeable in sheet performLayout * Update resize logic --------- Co-authored-by: Hari07 <[email protected]>
* feat: add draggable property to CupertinoSheetRoute it seems like a nice addition to me to let users customise this behaviour, also it might mitigate some scrolling issues users have. * chore: reformatted changed content --------- Co-authored-by: Jaime Blasco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )