chore: Reorder and update some strings #118
Conversation
* init: Workflow to notify discord users of releases * Rename workflow * chore (Background playback): Shorten description * Revert "chore (Background playback): Shorten description" This reverts commit 10661b8. * Change message contents
patches/src/main/resources/youtube/settings/host/values/strings.xml
Outdated
Show resolved
Hide resolved
ILoveOpenSourceApplications
changed the base branch from
revanced-extended
to
dev
ILoveOpenSourceApplications
changed the base branch from
dev
to
revanced-extended
patches/src/main/resources/youtube/settings/host/values/strings.xml
Outdated
Show resolved
Hide resolved
patches/src/main/resources/youtube/settings/host/values/strings.xml
Outdated
Show resolved
Hide resolved
patches/src/main/resources/youtube/settings/xml/revanced_prefs.xml
Outdated
Show resolved
Hide resolved
|
|
||
| <!-- SETTINGS: SHORTS_REPEAT_STATE_BACKGROUND | ||
| <ListPreference android:entries="@array/revanced_change_shorts_repeat_state_entries" android:title="@string/revanced_change_shorts_background_repeat_state_title" android:key="revanced_change_shorts_background_repeat_state" android:entryValues="@array/revanced_change_shorts_repeat_state_entry_values" />SETTINGS: SHORTS_REPEAT_STATE_BACKGROUND --> | ||
| <!-- SETTINGS: SHORTS_REPEAT_STATE |
There was a problem hiding this comment.
Identifier SETTINGS: SHORTS_REPEAT_STATE_BACKGROUND is missing.
There was a problem hiding this comment.
Is this being called somewhere, where if I renamed it something might fail?
|
|
||
| <!-- PREFERENCE_SCREEN: VIDEO | ||
| <SwitchPreference android:title="@string/revanced_reject_av1_codec_title" android:key="revanced_reject_av1_codec" android:summary="@string/revanced_reject_av1_codec_summary" /> | ||
| <SwitchPreference android:title="@string/revanced_replace_av1_codec_title" android:key="revanced_replace_av1_codec" android:summary="@string/revanced_replace_av1_codec_summary" /> |
There was a problem hiding this comment.
It's better to group video codec settings.
There was a problem hiding this comment.
Can we give it a preference category of its own then?
| @@ -790,6 +790,13 @@ | |||
| <app.revanced.extension.youtube.settings.preference.ImportExportPreference android:title="@string/revanced_extended_settings_import_export_as_text_title" android:summary="@string/revanced_extended_settings_import_export_as_text_summary" android:inputType="textMultiLine" /> | |||
| </PreferenceScreen> | |||
|
|
|||
| <app.revanced.extension.youtube.settings.preference.OpenDefaultAppSettingsPreference android:title="@string/revanced_default_app_settings_title" android:key="revanced_default_app_settings" android:summary="@string/revanced_default_app_settings_summary" /> | |||
There was a problem hiding this comment.
The Open default app settings and Open GmsCore Settings settings are located between the Import / Export settings and Spoof streaming data categories.
Categories are sorted first, then settings.
There was a problem hiding this comment.
Can't those two be considered as categories as they do redirect the user to a secondary page?
There was a problem hiding this comment.
I didn't group them because I couldn't think of a suitable category name.
There was a problem hiding this comment.
Do they really need to be categorized for this? When I think of Import / Export settings or Spoof streaming data at the beginning, I'm thinking "its because they take me to another settings page with its own set of options", which is what Open GmsCore settings and Open default app settings does, they take to their own individual app settings page.
There was a problem hiding this comment.
The same is being followed in ReVanced as well.
| <string name="revanced_default_app_settings_title">Open default app settings</string> | ||
| <string name="revanced_default_app_settings_summary">To open YouTube links in RVX, enable \'Open supported links\' and enable the supported web addresses.</string> | ||
|
|
||
| <string name="gms_core_settings_title">Open GmsCore Settings</string> |
There was a problem hiding this comment.
In Open default app settings, settings is lowercase, but in Open GmsCore Settings, Settings is uppercase.
There was a problem hiding this comment.
When opening GmsCore, the page opened says microG Settings, which is why I gave it a capital S.
patches/src/main/resources/youtube/settings/host/values/strings.xml
Outdated
Show resolved
Hide resolved
|
Unlike YouTube, YouTube Music cannot properly apply lexicographical order (due to limitations in patch structure). |
|
Oh, that's unfortunate. Anyways I've done the necessary changes for it if the limitation is bypassed at some point. |
patches/src/main/resources/music/settings/host/values/strings.xml
Outdated
Show resolved
Hide resolved
|
Thanks |
ILoveOpenSourceApplications
deleted the
chore-update-and-reorder-strings
branch
|
@inotia00, can you answer the unresolved reviews? I just want to get a clarity on why you reverted some of the changes. |
Closes inotia00/ReVanced_Extended#2647