Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reorder and update some strings #118

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6499b7d
ci: workflow to ping Discord users when patches are released (#72)
KobeW50 Aug 11, 2024
2e32741
Merge branch 'dev' into revanced-extended
inotia00 Aug 12, 2024
c57de97
Merge branch 'dev' into revanced-extended
inotia00 Sep 7, 2024
b725e54
Merge branch 'dev' into revanced-extended
inotia00 Sep 28, 2024
934c33a
Merge branch 'dev' into revanced-extended
inotia00 Oct 12, 2024
d8ae741
Merge branch 'dev' into revanced-extended
inotia00 Oct 21, 2024
807494f
Merge branch 'dev' into revanced-extended
inotia00 Nov 8, 2024
b5fe136
Merge branch 'dev' into revanced-extended
inotia00 Dec 8, 2024
5088daa
Merge branch 'dev' into revanced-extended
inotia00 Dec 8, 2024
2b0f12c
Merge branch 'dev' into revanced-extended
inotia00 Dec 9, 2024
0384907
Merge branch 'dev' into revanced-extended
inotia00 Dec 21, 2024
03c0826
Merge branch 'dev' into revanced-extended
inotia00 Dec 22, 2024
a9408b0
Merge branch 'dev' into revanced-extended
inotia00 Dec 22, 2024
ee0a7b5
Merge branch 'dev' into revanced-extended
inotia00 Dec 22, 2024
1aaf03d
Merge branch 'dev' into revanced-extended
inotia00 Jan 7, 2025
0485083
chore(YouTube): Re-order settings
ILoveOpenSourceApplications Jan 7, 2025
8bd0e98
chore: Re-order and rename some strings
ILoveOpenSourceApplications Jan 7, 2025
ef384e8
for consistency
ILoveOpenSourceApplications Jan 7, 2025
ecddbe9
update strings again
ILoveOpenSourceApplications Jan 7, 2025
aceb980
more updated strings
ILoveOpenSourceApplications Jan 7, 2025
5495b15
change option location
ILoveOpenSourceApplications Jan 7, 2025
df94a06
update settings location
ILoveOpenSourceApplications Jan 7, 2025
a79bc50
chore: update more strings
ILoveOpenSourceApplications Jan 7, 2025
4042fe6
chore: update and reorder even more strings
ILoveOpenSourceApplications Jan 8, 2025
899ff9f
fix typo
ILoveOpenSourceApplications Jan 8, 2025
fe20d5f
improve description
ILoveOpenSourceApplications Jan 8, 2025
7394412
feat: Apply code review suggestions
inotia00 Jan 13, 2025
ff828e8
fix: Fix build errors
inotia00 Jan 13, 2025
26ccad3
feat: Apply code review suggestions
inotia00 Jan 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public class Settings extends BaseSettings {


// PreferenceScreen: Flyout menu
public static final BooleanSetting ENABLE_COMPACT_DIALOG = new BooleanSetting("revanced_enable_compact_dialog", TRUE);
public static final BooleanSetting ENABLE_TRIM_SILENCE = new BooleanSetting("revanced_enable_trim_silence", FALSE, true);
public static final BooleanSetting ENABLE_COMPACT_DIALOG = new BooleanSetting("revanced_enable_compact_dialog", TRUE);
public static final BooleanSetting HIDE_FLYOUT_MENU_LIKE_DISLIKE = new BooleanSetting("revanced_hide_flyout_menu_like_dislike", FALSE, true);
public static final BooleanSetting HIDE_FLYOUT_MENU_3_COLUMN_COMPONENT = new BooleanSetting("revanced_hide_flyout_menu_3_column_component", FALSE, true);
public static final BooleanSetting HIDE_FLYOUT_MENU_ADD_TO_QUEUE = new BooleanSetting("revanced_hide_flyout_menu_add_to_queue", FALSE, true);
Expand Down Expand Up @@ -98,15 +98,15 @@ public class Settings extends BaseSettings {
public static final StringSetting CUSTOM_FILTER_STRINGS = new StringSetting("revanced_custom_filter_strings", "", true);
public static final BooleanSetting HIDE_BUTTON_SHELF = new BooleanSetting("revanced_hide_button_shelf", FALSE, true);
public static final BooleanSetting HIDE_CAROUSEL_SHELF = new BooleanSetting("revanced_hide_carousel_shelf", FALSE, true);
public static final BooleanSetting HIDE_PLAYLIST_CARD_SHELF = new BooleanSetting("revanced_hide_playlist_card_shelf", FALSE, true);
public static final BooleanSetting HIDE_SAMPLE_SHELF = new BooleanSetting("revanced_hide_samples_shelf", FALSE, true);
public static final BooleanSetting HIDE_CAST_BUTTON = new BooleanSetting("revanced_hide_cast_button", TRUE);
public static final BooleanSetting HIDE_CATEGORY_BAR = new BooleanSetting("revanced_hide_category_bar", FALSE, true);
public static final BooleanSetting HIDE_FLOATING_BUTTON = new BooleanSetting("revanced_hide_floating_button", FALSE, true);
public static final BooleanSetting HIDE_TAP_TO_UPDATE_BUTTON = new BooleanSetting("revanced_hide_tap_to_update_button", FALSE, true);
public static final BooleanSetting HIDE_HISTORY_BUTTON = new BooleanSetting("revanced_hide_history_button", FALSE);
public static final BooleanSetting HIDE_NOTIFICATION_BUTTON = new BooleanSetting("revanced_hide_notification_button", FALSE, true);
public static final BooleanSetting HIDE_PLAYLIST_CARD_SHELF = new BooleanSetting("revanced_hide_playlist_card_shelf", FALSE, true);
public static final BooleanSetting HIDE_SAMPLE_SHELF = new BooleanSetting("revanced_hide_samples_shelf", FALSE, true);
public static final BooleanSetting HIDE_SOUND_SEARCH_BUTTON = new BooleanSetting("revanced_hide_sound_search_button", FALSE, true);
public static final BooleanSetting HIDE_TAP_TO_UPDATE_BUTTON = new BooleanSetting("revanced_hide_tap_to_update_button", FALSE, true);
public static final BooleanSetting HIDE_VOICE_SEARCH_BUTTON = new BooleanSetting("revanced_hide_voice_search_button", FALSE, true);
public static final BooleanSetting REMOVE_VIEWER_DISCRETION_DIALOG = new BooleanSetting("revanced_remove_viewer_discretion_dialog", FALSE);
public static final BooleanSetting RESTORE_OLD_STYLE_LIBRARY_SHELF = new BooleanSetting("revanced_restore_old_style_library_shelf", FALSE, true);
Expand All @@ -128,21 +128,21 @@ public class Settings extends BaseSettings {


// PreferenceScreen: Player
public static final BooleanSetting ENABLE_MINI_PLAYER_NEXT_BUTTON = new BooleanSetting("revanced_enable_mini_player_next_button", TRUE, true);
public static final BooleanSetting ENABLE_MINI_PLAYER_PREVIOUS_BUTTON = new BooleanSetting("revanced_enable_mini_player_previous_button", TRUE, true);
public static final BooleanSetting ENABLE_COLOR_MATCH_PLAYER = new BooleanSetting("revanced_enable_color_match_player", TRUE);
public static final BooleanSetting ENABLE_BLACK_PLAYER_BACKGROUND = new BooleanSetting("revanced_enable_black_player_background", FALSE, true);
public static final BooleanSetting DISABLE_MINI_PLAYER_GESTURE = new BooleanSetting("revanced_disable_mini_player_gesture", FALSE, true);
public static final BooleanSetting DISABLE_PLAYER_GESTURE = new BooleanSetting("revanced_disable_player_gesture", FALSE, true);
public static final BooleanSetting ENABLE_BLACK_PLAYER_BACKGROUND = new BooleanSetting("revanced_enable_black_player_background", FALSE, true);
public static final BooleanSetting ENABLE_COLOR_MATCH_PLAYER = new BooleanSetting("revanced_enable_color_match_player", TRUE);
public static final BooleanSetting ENABLE_FORCE_MINIMIZED_PLAYER = new BooleanSetting("revanced_enable_force_minimized_player", TRUE);
public static final BooleanSetting ENABLE_MINI_PLAYER_NEXT_BUTTON = new BooleanSetting("revanced_enable_mini_player_next_button", TRUE, true);
public static final BooleanSetting ENABLE_MINI_PLAYER_PREVIOUS_BUTTON = new BooleanSetting("revanced_enable_mini_player_previous_button", TRUE, true);
public static final BooleanSetting ENABLE_SWIPE_TO_DISMISS_MINI_PLAYER = new BooleanSetting("revanced_enable_swipe_to_dismiss_mini_player", TRUE, true);
public static final BooleanSetting ENABLE_ZEN_MODE = new BooleanSetting("revanced_enable_zen_mode", FALSE);
public static final BooleanSetting ENABLE_ZEN_MODE_PODCAST = new BooleanSetting("revanced_enable_zen_mode_podcast", FALSE);
public static final BooleanSetting HIDE_AUDIO_VIDEO_SWITCH_TOGGLE = new BooleanSetting("revanced_hide_audio_video_switch_toggle", FALSE, true);
public static final BooleanSetting HIDE_COMMENT_CHANNEL_GUIDELINES = new BooleanSetting("revanced_hide_comment_channel_guidelines", TRUE);
public static final BooleanSetting HIDE_COMMENT_TIMESTAMP_AND_EMOJI_BUTTONS = new BooleanSetting("revanced_hide_comment_timestamp_and_emoji_buttons", FALSE);
public static final BooleanSetting HIDE_DOUBLE_TAP_OVERLAY_FILTER = new BooleanSetting("revanced_hide_double_tap_overlay_filter", FALSE, true);
public static final BooleanSetting HIDE_COMMENT_TIMESTAMP_AND_EMOJI_BUTTONS = new BooleanSetting("revanced_hide_comment_timestamp_and_emoji_buttons", FALSE);
public static final BooleanSetting HIDE_FULLSCREEN_SHARE_BUTTON = new BooleanSetting("revanced_hide_fullscreen_share_button", FALSE, true);
public static final BooleanSetting HIDE_AUDIO_VIDEO_SWITCH_TOGGLE = new BooleanSetting("revanced_hide_audio_video_switch_toggle", FALSE, true);
public static final BooleanSetting REMEMBER_REPEAT_SATE = new BooleanSetting("revanced_remember_repeat_state", TRUE);
public static final BooleanSetting REMEMBER_SHUFFLE_SATE = new BooleanSetting("revanced_remember_shuffle_state", TRUE);
public static final BooleanSetting ALWAYS_SHUFFLE = new BooleanSetting("revanced_always_shuffle", FALSE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@ public CommentsFilter() {
"sponsorships_comments_footer.eml"
);

final StringFilterGroup liveChatMessages = new StringFilterGroup(
Settings.HIDE_LIVE_CHAT_MESSAGES,
"live_chat_text_message",
"viewer_engagement_message" // message about poll, not poll itself
);

final StringFilterGroup liveChatSummary = new StringFilterGroup(
Settings.HIDE_LIVE_CHAT_SUMMARY,
"live_chat_summary_banner"
);

final StringFilterGroup previewComment = new StringFilterGroup(
Settings.HIDE_PREVIEW_COMMENT_OLD_METHOD,
"|carousel_item.",
Expand Down Expand Up @@ -88,6 +99,8 @@ public CommentsFilter() {
commentsPreviewDots,
createShorts,
membersBanner,
liveChatMessages,
liveChatSummary,
previewComment,
previewCommentText,
thanks,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,6 @@ public PlayerComponentsFilter() {
"single_item_information_panel"
);

final StringFilterGroup liveChatMessages = new StringFilterGroup(
Settings.HIDE_LIVE_CHAT_MESSAGES,
"live_chat_text_message",
"viewer_engagement_message" // message about poll, not poll itself
);

final StringFilterGroup liveChatSummary = new StringFilterGroup(
Settings.HIDE_LIVE_CHAT_SUMMARY,
"live_chat_summary_banner"
);

final StringFilterGroup medicalPanel = new StringFilterGroup(
Settings.HIDE_MEDICAL_PANEL,
"emergency_onebox",
Expand Down Expand Up @@ -96,8 +85,6 @@ public PlayerComponentsFilter() {
channelWaterMark,
infoCards,
infoPanel,
liveChatMessages,
liveChatSummary,
medicalPanel,
seekMessage,
suggestedActions,
Expand Down
Loading