Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update preference screen title casing #127

Conversation

ILoveOpenSourceApplications

Changes done according to #122 (comment).

@inotia00
Copy link
Owner

@KobeW50 How to change the format of the title in PreferenceScreen?

On YouTube, it is expressed as: Alternative tumbnails, Account menu

On YouTube Music, it is expressed as: Action Bar, Flyout Menu, Navigation Bar

It seems better to follow one of the two formats.

@ILoveOpenSourceApplications

This comment was marked as resolved.

@KobeW50
Copy link
Collaborator

KobeW50 commented Jan 18, 2025

The native settings menus in YouTube and YT Music are sentence-cased (ex: Data saving)

RVX menu titles should follow the same format. Only the first word should be capitalized except when it's a proper noun.

I mean @KobeW50, did suggest the current PR change (see the PR description) , which I'm doing now for consistency across both the apps.

Oops this is entirely my fault. I misused the term "title-cased". I am sorry for your trouble.

I meant that "Flyout Menu" and "Action Bar" should be changed to "Flyout menu" and "Action bar"

I'll make the changes in a few hours when I'm on my laptop so that you don't work twice as much due to my mistake.

@ILoveOpenSourceApplications

This comment was marked as outdated.

@inotia00
Copy link
Owner

Also, we use "Experimental Flags" instead of "Experimental flags". That should be changed as well, right?

Yeah, Experimental flags seems more appropriate.

@inotia00
Copy link
Owner

Thanks!

@inotia00 inotia00 merged commit 49ac337 into inotia00:dev Jan 19, 2025
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the chore/update-preference-screen-casing branch January 19, 2025 06:05
@inotia00 inotia00 mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants