Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clarify strings #130

Merged

Conversation

ILoveOpenSourceApplications

The name Live ring was obtained from the below source.

Screenshot 2025-01-19 010245

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Adds an option to change the dp in order to use a tablet or phone layout.

I believe it's supposed to be dpi.

I didn't mean to review, just leave a comment. Sorry about that.

@ILoveOpenSourceApplications
Copy link
Author

No actually.

  • Because dp (Density-Independent Pixels) is a unit for defining UI element sizes in a density-independent way, ensuring consistency across devices.
  • Whereas, dpi (Dots Per Inch) is a measure of the pixel density of a display, affecting the sharpness and clarity of images.

@inotia00
Copy link
Owner

Since the previous PR has already been merged, I will add this suggestion to this PR.

@inotia00 inotia00 merged commit 181bcb1 into inotia00:dev Jan 19, 2025
@ILoveOpenSourceApplications ILoveOpenSourceApplications deleted the chore/clarify-strings branch January 19, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants