Depend on train-core via the Gemfile, not train #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <[email protected]>
zenspider
approved these changes
Aug 7, 2019
Signed-off-by: Clinton Wolfe <[email protected]>
zenspider
approved these changes
Aug 8, 2019
miah
approved these changes
Aug 8, 2019
|
Looks good, but you might want to change the title since you're really not depending on either. |
clintoncwolfe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clinton Wolfe [email protected]
Description
It was pointed out that the train plugins should rely on train-core, not train, so that chef and others can pull train-winrm without pulling in other heavy dependencies.
This changes the dep to be on train-core, and moves the dep to the Gemfile, so cconsumers can do a sibling gem dependency on either train or train-core as they see fit.
Related Issue
Types of changes
Checklist: