Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on train-core via the Gemfile, not train #12

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Depend on train-core via the Gemfile, not train #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f30cb1e
Depend on train-core, not train
clintoncwolfe Aug 7, 2019
d41acb7
Move train-core dep to Gemfile
clintoncwolfe Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ gemspec

# Remaining group is only used for development.
group :development do
# Depend on this here, not in the gemspec - to avoid having to have
# client applications induce circular dependencies
gem "train-core", "~> 3.0"
gem "bundler"
gem "byebug"
gem "m"
Expand Down
3 changes: 1 addition & 2 deletions train-winrm.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ Gem::Specification.new do |spec|
# them in Gemfile, not here.

# Do not list inspec as a dependency of a train plugin.

spec.add_dependency "train", "~> 3.0"
# Do not list train or train-core as a dependency of a train plugin.
spec.add_dependency "winrm", "~> 2.0"
spec.add_dependency "winrm-fs", "~> 1.0"
end