Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FeatureTransforms #50

Merged
merged 23 commits into from
Apr 22, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put _pattern back into impute.jl
  • Loading branch information
bencottier authored and Glenn Moynihan committed Apr 22, 2021
commit 1bd8a0a095d0f701e653107be4cebe004f70e168
1 change: 0 additions & 1 deletion src/AxisSets.jl
Original file line number Diff line number Diff line change
@@ -90,6 +90,5 @@ include("indexing.jl")
include("functions.jl")
include("impute.jl")
include("featuretransforms.jl")
include("utils.jl")

end
4 changes: 4 additions & 0 deletions src/impute.jl
Original file line number Diff line number Diff line change
@@ -126,6 +126,10 @@ julia> [k => parent(parent(v)) for (k, v) in Impute.filter(ds; dims=:loc).data]
"""
Impute.apply(ds::KeyedDataset, f::Filter; dims) = Impute.apply!(deepcopy(ds), f; dims=dims)

_pattern(dims::Pattern) = dims
_pattern(dims::Tuple) = Pattern(dims)
_pattern(dims) = Pattern(:__, dims)

function Impute.apply!(ds::KeyedDataset, f::Filter; dims)
pattern = _pattern(dims)
dim = pattern.segments[end]
5 changes: 0 additions & 5 deletions src/utils.jl

This file was deleted.