Support FeatureTransforms #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmoy
commented
Apr 21, 2021
| (:predict, :price) => [0.25 1.0; 25.0 4.0; 0.0 1.0] | ||
| ``` | ||
| """ | ||
| function FeatureTransforms.apply(ds::KeyedDataset, t::Transform, key=Pattern((:__,)); kwargs...) |
There was a problem hiding this comment.
I remove dims because it is already being used in the underlying FeatureTransforms methods so I don't think we should be using for special purposes here. At least not for now.
For FeatureTransforms compat
Also update docstrings of apply and _apply_paths
- Map simplifies things - don't need the custom _apply_paths() anymore - Returning full dataset seems more appropriate after talking to Rory
This reverts commit f85a135.
glennmoy
force-pushed
the
gm/featuretransforms
branch
from
77cf9f1 to
d99a661
Compare
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 98.93% 98.60% -0.34%
==========================================
Files 7 9 +2
Lines 283 287 +4
==========================================
+ Hits 280 283 +3
- Misses 3 4 +1
Continue to review full report at Codecov.
|
glennmoy
commented
Apr 22, 2021
rofinn
approved these changes
Apr 22, 2021
added 2 commits
April 22, 2021 21:04
glennmoy
force-pushed
the
gm/featuretransforms
branch
from
2553617 to
52c6b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branched off https://github.com/invenia/AxisSets.jl/tree/bc/featuretransforms and partially replaces #44
apply!andapply_appendmethods for now since all we need isapplyfor KeyedDataset to beis_transformablekeyargument for similar reasons - now it looks more likeImpute.applymethod so I also replaced the original_patternmethods.