Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement general case non-mutating apply #15

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Conversation

nicoleepp
Copy link
Contributor

Part of #12

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #15 (c0cff1a) into main (2e23f97) will decrease coverage by 7.57%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main      #15      +/-   ##
===========================================
- Coverage   100.00%   92.42%   -7.58%     
===========================================
  Files            6        6              
  Lines           69       66       -3     
===========================================
- Hits            69       61       -8     
- Misses           0        5       +5     
Impacted Files Coverage Δ
src/transformers.jl 95.23% <90.00%> (-4.77%) ⬇️
src/periodic.jl 100.00% <100.00%> (ø)
src/power.jl 100.00% <100.00%> (ø)
src/utils.jl 0.00% <0.00%> (-100.00%) ⬇️
src/linear_combination.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e23f97...2becaea. Read the comment docs.

src/transformers.jl Outdated Show resolved Hide resolved
test/periodic.jl Outdated Show resolved Hide resolved
@nicoleepp nicoleepp mentioned this pull request Feb 10, 2021
4 tasks
Copy link
Contributor

@bencottier bencottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few suggestions and uncertainties.

src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
src/periodic.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
test/periodic.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
src/transformers.jl Show resolved Hide resolved
src/transformers.jl Outdated Show resolved Hide resolved
@nicoleepp nicoleepp merged commit 670f4b3 into main Feb 11, 2021
@nicoleepp nicoleepp deleted the ne/general-apply branch February 11, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants