Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia >=1.3 versions #86

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Support Julia >=1.3 versions #86

merged 1 commit into from
Apr 22, 2021

Conversation

glennmoy
Copy link
Member

@glennmoy glennmoy commented Apr 22, 2021

should help with integrating into invenia/AxisSets.jl#50

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #86 (de396bf) into main (43a2cc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          12       12           
  Lines         135      135           
=======================================
  Hits          134      134           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a2cc7...de396bf. Read the comment docs.

@glennmoy glennmoy force-pushed the gm/julia1 branch 3 times, most recently from f8cd0a7 to fbb5287 Compare April 22, 2021 16:18
@glennmoy glennmoy changed the title Support all Julia 1 versions Support Julia >=1.3 versions Apr 22, 2021
@@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
version:
- "1.5" # Invenia Prod version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still add test specifically for 1.5

@rofinn rofinn assigned rofinn and unassigned rofinn Apr 22, 2021
@rofinn rofinn self-requested a review April 22, 2021 17:06
Copy link
Member

@rofinn rofinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glennmoy glennmoy merged commit 86efefa into main Apr 22, 2021
@glennmoy glennmoy deleted the gm/julia1 branch April 22, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants