Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #136

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.32, 0.33 to 0.32, 0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@rofinn rofinn force-pushed the compathelper/new_version/2023-05-02-00-16-25-271-02823867284 branch from 11984de to 99b73ee Compare May 2, 2023 00:16
@svilupp
Copy link

svilupp commented Aug 29, 2023

Hi everyone,

Would it be possible to bump up the compat? Impute.jl is a dependency of DataFrames.jl, so it's holding back a lot of projects from upgrading to StatsBase 0.34.

I wanted to check the CI failures, but the logs have expired. Would it be possible to re-run it?

@rofinn
Copy link
Member

rofinn commented Aug 29, 2023

Can you point me to where DataFrames is depending on Impute cause it shouldn't? Looking at the Project.toml, DataFrames doesn't depend on Impute, and Impute only uses DataFrames as a test dependency.

@rofinn
Copy link
Member

rofinn commented Aug 29, 2023

Regardless, bumping this should be fine for now. The test are failing on Julia 1.9 and higher because we don't have the latest AxisKeys release.

@rofinn rofinn merged commit 338775e into master Aug 29, 2023
@rofinn rofinn deleted the compathelper/new_version/2023-05-02-00-16-25-271-02823867284 branch August 29, 2023 18:21
@svilupp
Copy link

svilupp commented Aug 29, 2023

Aaah, my bad! I misread the output of the dependency graph... You're right that it's not a dep for DataFrames!
It was coming from a different package and when I locally bumped it up, it all started working, so I haven't investigated further.

Thank you for responding so quickly!

@rofinn
Copy link
Member

rofinn commented Aug 29, 2023

Looks like there is a minor issue with bumping StatsBase in that it identified a numeric instability with our KNN tests. Shouldn't block a release, but will need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants