Update Project.toml and DataDep #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump AxisKeys and patch release number.
rofinn
commented
Aug 29, 2023
Comment on lines
+6
to
+8
| "https://www.dropbox.com/scl/fi/bgtfqea9qqoug42gcnnsl/datasets.tar.gz?rlkey=11xsae0wi32m8gcfxhbqgo030&dl=0", | ||
| "cf1fff2e7f3ce28eb4264060bc7b9ee561bccfce2c5915c4cf758ec48477ddfe", | ||
| fetch_method=DataDeps.fetch_base, |
There was a problem hiding this comment.
- Dropbox view link. Bug @rofinn if there are issues.
- I don't know why the hash is different, but it's possible my local copy was slightly out-of-date
- HTTP.jl wasn't downloading the entire file for some reason, so we're using
Base.downloadinstead.
…tor to after condition.
rofinn
commented
Aug 29, 2023
| @@ -73,13 +73,16 @@ function impute!(data::AbstractMatrix{Union{T, Missing}}, imp::KNN; dims=nothing | |||
|
|
|||
| # Weight valid neighbors based on inverse distance | |||
| neighbor_dists = dists[.!neighbor_mask] | |||
| wv = weights(1.0 ./ neighbor_dists) | |||
|
|
|||
| # Delay creating Weights as they don't support Inf or NaN anymore. | |||
There was a problem hiding this comment.
As of #136 we can't call weights with a vector containing Inf, so we're just computing the sum ourselves and calling Weights for the weighted mean.
|
I'm guessing we need to drop 1.5 at some point. |
1.5 is pretty old and many of our deps aren't supporting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump AxisKeys and patch release number.