Feat/tanlang/add more cmd / 增加更多功能和命令 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinZexiao
force-pushed
the
feat/tanlang/add-more-cmd
branch
from
d050820 to
e29530a
Compare
LinZexiao
changed the title
simlecode
reviewed
Dec 29, 2022
| }, | ||
| } | ||
|
|
||
| var minerSetAskCmd = &cli.Command{ |
diwufeiwen
reviewed
Dec 29, 2022
hunjixin
reviewed
Dec 30, 2022
route/wrap.go
Outdated
|
|
||
| var err error | ||
|
|
||
| if ctx.Request.ContentLength > 0 { |
There was a problem hiding this comment.
这样写感觉还是蛮奇怪的，这意思就是客户端有几种传值的办法？
There was a problem hiding this comment.
是的,尽可能兼容 多种传参方式,因为不能直接判断 是不是带了 body,就只能用间接的方法了
hunjixin
reviewed
Dec 30, 2022
service/service.go
Outdated
| return cid, err | ||
| } | ||
|
|
||
| func (s *Service) AddrOperate(ctx context.Context, params *AddrsOperateReq) error { |
There was a problem hiding this comment.
待商榷的功能，目前只需要给个更新参数就行，其他的没必要做。
There was a problem hiding this comment.
目前已经实现了的话,不确定要不要就先保留,明确不要再删掉?
hunjixin
reviewed
Dec 30, 2022
service/service.go
Outdated
| } | ||
| } | ||
|
|
||
| ret, err := s.Messager.GetMessageByUid(ctx, params.MsgId) |
There was a problem hiding this comment.
不需要等待,这个接口是无状态可重入的, 只要客户端那边 定时轮询就好
hunjixin
reviewed
Dec 30, 2022
route/route.go
Outdated
|
|
||
| dealGroup := apiV0Group.Group("/deal") | ||
| dealGroup.GET("storage", Wrap(s.DealStorageList)) | ||
| dealGroup.GET("retrieval", Wrap(s.DealRetrievalList)) |
There was a problem hiding this comment.
是的,所以目前返回的结果是所有的,这个要去掉吗?
supply feedback after cmd exec change logger name to cli from cmd fix verbose flag fix err check
LinZexiao
changed the base branch from
feat/tanlang/add-ability-to-send-msg
to
master
diwufeiwen
reviewed
Dec 30, 2022
return err rather than panic when create client
…client-with-api Feat/tanlang/replace client with api / 用封装好的 api 代替 httpClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
ref filecoin-project/venus#5304
Detail
新增命令