fix: api host, port and protocol #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this linked to #611 ? |
|
Yes @koalalorenzo |
|
Does it work with your setup @koalalorenzo ? |
|
I had no time to test it, but I will check it today or tomorrow. I hope that this will make to the next release (0.4.14) |
|
I am not really able to test this as I need to modify the source code here: https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/webui.go#L4 and deploy it with a valid certificate for https. I guess this was not shipped in 0.4.14 |
|
Hi, I made a fix to this in another pull request (#664) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.