Fix support for use behind https #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't wait to get this merged (almost a month passed) |
|
We're working on a rebuild of the webui, and we'll ensure it works behind https. As a regular reminder, don't expose your API port to the public internet. That said, the current UI should work via https, so this PR is very much welcome, let's get it in! @hacdias can you test and review this change? I think it also fixes the issue in this comment #653 (comment) |
|
@olizilla gonna take a look! |
|
Seems to be working. Thanks @danieldaf 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix and test the use of https related to the pull request #639 and the issue #611