This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
[WIP] perf: reduce bundle size #1795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
suggested changes
Jan 18, 2019
There was a problem hiding this comment.
Some pretty impressive size reductions here, good work! Just need to remove all the branch versions from package.json and resolve the conflicts.
I see you swapped out joi for superstruct to validate the config - is this something we should be doing throughout the project?
test/http-api/inject/pin.js
Outdated
| @@ -115,7 +115,7 @@ module.exports = (http) => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('ls', () => { | |||
| describe.only('ls', () => { | |||
|
@hugomrdias are you still tracking this? Can you list out the dependent PRs in the description above so I can help you push them along? |
|
waiting on mplex we are getting there just a little bit longer |
hugomrdias
force-pushed
the
fix/bundle-size
branch
from
b9809a6 to
7568612
Compare
alanshaw
suggested changes
Mar 18, 2019
| return mergeOptions({ | ||
| blockService: blockService | ||
| }, options) | ||
| } |
There was a problem hiding this comment.
Until we have multiple browser builds we need to include bitcoin, ethereum, git and zcash.
Co-Authored-By: hugomrdias <[email protected]>
Co-Authored-By: hugomrdias <[email protected]>
This was referenced Mar 22, 2019
|
Shall we close this one @hugomrdias? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before/After:
modules 1549 946 -38.92%
unminified 8 617 735 3 629 020 -57.88893485%
minified 3 007 790 1 439 307 -52.14735736%
minified+gzip 773.59 386.56 -50.03037785%
Analyzer
https://bundle-size.netlify.com/ipfs-before.html
https://bundle-size.netlify.com/ipfs-after.html