This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: swap joi-browser with superstruct #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
this is failing because of #1955 |
|
@hugomrdias #1955 is now merged - can we get CI 🍏 for this one now? |
The validation is now a bit more strict. Relay config is removed because libp2p already validates it. A bug was detected and fixed because the validation is stricter. This should improve the overall bundle size and safety handling the config.
hugomrdias
force-pushed
the
fix/bundle-size-remove-joi
branch
from
fd9f38a to
9f46e9a
Compare
|
@alanshaw ready to merge |
alanshaw
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation is now a bit more strict.
Relay config is removed because libp2p already validates it.
A bug was detected and fixed because the validation is stricter.
This should improve the overall bundle size and safety of handling the config.
This PR is a subset of #1795 to make review and merge easier.