refactor(backend): use process.exit instead of throw

For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163 There is also a fix in the `onError signature` (which in reality had void returns) Signed-off-by: Fernando Fernández <[email protected]>
isa-group · Dec 12, 2024 · 47aeb4b · 47aeb4b
1 parent fac4ce1
commit 47aeb4b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/packages/backend/package.json b/packages/backend/package.json
@@ -9,7 +9,7 @@
     "start": "npm run prisma && NODE_OPTIONS='--experimental-strip-types' NODE_NO_WARNINGS=1 npm run listhen:dev",
     "prod": "npm run prisma && NODE_OPTIONS='--experimental-strip-types' NODE_NO_WARNINGS=1 npm run listhen:prod",
     "listhen:dev": "DEV=1 listhen -w ./src/app.ts",
-    "listhen:prod": "listhen --host --qr false ./src/app.ts",
+    "listhen:prod": "listhen --public --qr false ./src/app.ts",
     "check": "npm run check:types",
     "check:types": "tsc",
     "lint": "eslint . --flag unstable_ts_config",

diff --git a/packages/backend/src/app.ts b/packages/backend/src/app.ts
@@ -1,7 +1,7 @@
 import { join } from 'node:path';
 import { mkdir } from 'node:fs/promises';
 import { seedDb } from './util/db.ts';
-import { createApp, createRouter, handleCors } from 'h3';
+import { createApp, createRouter, handleCors, sendNoContent } from 'h3';
 import { isDev } from './util/logger.ts';
 import { registerDynamicModules } from './util/dynamic-modules.ts';
 import { destr } from 'destr';
@@ -37,7 +37,7 @@ registerMailing();
  */
 export const app = createApp({
   debug: isDev,
-  onError: () => new Response(null, { status: 500 }),
+  onError: (_, event) => sendNoContent(event, 500),
   onRequest: (event) => {
     handleCors(event, {
       origin: isDev || Boolean(process.env.ALLOW_ALL_CORS) ? '*' : destr(process.env.CORS_ORIGINS),

diff --git a/packages/backend/src/redsys.ts b/packages/backend/src/redsys.ts
@@ -21,7 +21,8 @@ if (!process.env.REDSYS_MERCHANT_CODE
   if (isDev) {
     console.warn(`${msg}.\nRedsys testing values will be used in development, but make sure to set those in production`);
   } else {
-    throw new Error(`${msg}.\nHalting...`);
+    console.error(`${msg}.\nHalting...`);
+    process.exit(1);
   }
 }
 

diff --git a/packages/backend/src/util/mailing/index.ts b/packages/backend/src/util/mailing/index.ts
@@ -20,7 +20,8 @@ if (!is_available) {
   if (isDev) {
     console.warn(`${msg}.\nContinuing without mailing capabilities, but make sure to set those in production`);
   } else {
-    throw new Error(`${msg}.\nPlease set those in the environment variables.\n\nHalting...`);
+    console.error(`${msg}.\nPlease set those in the environment variables.\n\nHalting...`);
+    process.exit(1);
   }
 }