Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing H3 errors #163

Closed
nainemom opened this issue Mar 2, 2024 · 1 comment
Closed

Capturing H3 errors #163

nainemom opened this issue Mar 2, 2024 · 1 comment

Comments

@nainemom
Copy link

nainemom commented Mar 2, 2024

Environment

os: linux mint
nodejs: v20.8.1
listhen: ^1.7.2
h3: ^1.11.1

Reproduction

https://gist.github.com/nainemom/93650c8efe74714e0fb6ba4193adc2f5

Describe the bug

onError prop on h3 app never reaches when the app started by listhen.

Additional context

I tried to use onError prop on h3 app object to capture my application error, however it doesn't run my error handler function at all. at first, I thought that it may be the h3 bug, but after few more tests, i realized that it's actually related to listhen.

In the reproduction gist, i created two script, one of them starts the app with listhen and the other one just start the app with nodejs itself and create web server with nodejs http module.
The app itself is so simple, just a simple /error route to throw an error.
Now if you try to use listhen to start the app, the error handler method never reaches, but with node it just works.

I also thought that it may tty mapping problem, but it seems not.

Logs

No response

@pi0
Copy link
Member

pi0 commented Mar 3, 2024

Thanks for detailed issue. It is linked with #111

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2024
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 12, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
ferferga added a commit to isa-group/bpm2025 that referenced this issue Dec 13, 2024
For some reason, listhen intercepts the unhadledRejection process, making global throws practically useless. See unjs/listhen#163

There is also a fix in the `onError signature` (which in reality had void returns)

Signed-off-by: Fernando Fernández <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants