-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds recorder manager in manager-based environments #1336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvcyc
requested review from
Mayankm96,
jsmith-bdai,
Dhoeller19 and
kellyguo11
as code owners
October 29, 2024 22:40
nvcyc
force-pushed
the
cy/recorder_manager
branch
2 times, most recently
from
November 2, 2024 19:08
37b6d9c
to
62087f0
Compare
nvcyc
force-pushed
the
cy/recorder_manager
branch
6 times, most recently
from
November 7, 2024 23:58
0e16d99
to
18f8f71
Compare
kellyguo11
reviewed
Nov 17, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/utils/test_episode_data.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
test_episode_data.py test seems to be failing |
jtigue-bdai
reviewed
Nov 18, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/recorders/recorders.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/test/managers/test_recorder_manager.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/recorder_manager.py
Outdated
Show resolved
Hide resolved
nvcyc
force-pushed
the
cy/recorder_manager
branch
3 times, most recently
from
November 26, 2024 17:11
afde2dd
to
3604590
Compare
nvcyc
force-pushed
the
cy/recorder_manager
branch
from
December 2, 2024 23:55
fe7e5fe
to
49d30cd
Compare
nvcyc
force-pushed
the
cy/recorder_manager
branch
from
December 4, 2024 00:10
ea91b75
to
3cb1d1d
Compare
kellyguo11
reviewed
Dec 4, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
Co-authored-by: Kelly Guo <[email protected]> Signed-off-by: CY Chen <[email protected]>
nvcyc
commented
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reviews. Comments are addressed.
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Show resolved
Hide resolved
jtigue-bdai
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for new feature. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a recorder manager (RecorderManager) and relevant utility classes for recording data produced in various reset and step stages in manager-based environments.
Wither the built-in recorder manager, users can create custom recorder terms in their environment configurations with callback functions returning tensors to be recorded as environments advance. It is particularly useful for implementing an app that collects human-operated demos and for those who want to record robot actions for post-validation/replay in Isaac Lab environments.
The recorder manager works in both single- and multi-environment use cases. An episode for an environment instance is exported to a dataset file, via a dataset file handler, upon completion (a termination term is signaled a reset to the environment instance is triggered).
By default, the recorder manager is inactive (by assigning no recorder terms in the default configuration), which should have minimal performance impact for existing apps that do not require data recording.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there