Fixes error in apply_actions method in NonHolonomicAction
action term.
#1513
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After indexing the size of
quad_w
in theapply_actions
method is (N,B,4) where B will always equal 1, since it is enforced in the__init__
that only one body name is passed to the action term config. However, theeuler_xyz_from_quat
method requires inputs to be size (N,4), and so an error is thrown for input size (N,1,4). This PR just creates a (N,4) view of quat_w to be passed toeuler_xyz_from_quat
. This simple change does not introduce any new warnings and works with a simple non holonomic robot, like the Clearpath Husky.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there