Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error in apply_actions method in NonHolonomicAction action term. #1513

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KyleM73
Copy link
Contributor

@KyleM73 KyleM73 commented Dec 8, 2024

Description

After indexing the size of quad_w in the apply_actions method is (N,B,4) where B will always equal 1, since it is enforced in the __init__ that only one body name is passed to the action term config. However, the euler_xyz_from_quat method requires inputs to be size (N,4), and so an error is thrown for input size (N,1,4). This PR just creates a (N,4) view of quat_w to be passed to euler_xyz_from_quat. This simple change does not introduce any new warnings and works with a simple non holonomic robot, like the Clearpath Husky.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Signed-off-by: Kyle Morgenstein <[email protected]>
Signed-off-by: Kyle Morgenstein <[email protected]>
Signed-off-by: Kyle Morgenstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant