Dockerfile: Set TOX_ENV to use artifacts from nodejs build instead of building inside Python container (fixes #759) #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
changed the title
Set `TOX_ENV` to avoid re-running the javascript generation step that has already been handled by the nodejs `jsBuilder` step. This causes the `NpmBuildCommand` inside `setup.py` to abort early. This fixes the Docker build as previously it would fail to compile javascript in a pure-python docker container. Fix isso-comments#759
|
Hey, thank you for your contribution! I can verify that this indeed does fix the docker build. To expand a bit: @alexandru please use proper commit messages next time. I've pushed to your branch to add more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what the purpose of that
TOX_ENVvalue was, but it seems to do the trick.