Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/gravatar display avatar size #831

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Mar 27, 2022

  • Fix display for larger avatar images
  • limit default gravatar images to the same 55px as the non gravatar images

I didn't see any negative effects of removing the 7% with but idk i guess it was there for a reason
Screenshot 2022-03-27 at 20-54-21 Binärgewitter Talk #292 USB Autobatterie
Screenshot 2022-03-27 at 20-53-51 Binärgewitter Talk #292 USB Autobatterie

@ix5
Copy link
Member

ix5 commented Mar 27, 2022

You might want to document that ?s=x sets the size of the generated avatar, and maybe also link to Gravatar.com: Image requests docs.

It should be noted that the default dimensions for Gravatar seem to be 80x80 pixels, documenting that might also be a good idea.

Re: The 7% width, I can't think of a valid reason for that either. Removing is fine.

Just one nit: isso.css with limit of 7% leads to weird spacing isn't a commit message, it's a statement. css: isso.css: Remove width=7% from div.avatar is better. Then you can explain the rationale in the message body.

Edit: Please also add a CHANGES entry so that people who use a custom gravatar URL (maybe ?d=retro instead of ?d=identicon) know to add the size parameter.

@ix5 ix5 added client (Javascript) client code and CSS bug labels Mar 27, 2022
@ix5 ix5 added this to the 0.13 milestone Mar 27, 2022
@ix5 ix5 mentioned this pull request Mar 27, 2022
@ix5 ix5 force-pushed the bugfix/gravatar-display-avatar-size branch from 35fcc23 to 6cb0377 Compare April 14, 2022 20:49
@ix5 ix5 merged commit f3adedf into isso-comments:master Apr 14, 2022
@fliiiix
Copy link
Contributor Author

fliiiix commented Apr 15, 2022

thanks for picking this up 🎉 i don't had time to work on it

@fliiiix fliiiix deleted the bugfix/gravatar-display-avatar-size branch April 15, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client (Javascript) client code and CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants