Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/gravatar display avatar size #831

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Bugfix/gravatar display avatar size #831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa3e49d
css: isso.css: Remove width=7% from div.avatar
fliiiix Mar 27, 2022
3814705
isso.conf: limit default gravatar to 55px
fliiiix Mar 27, 2022
6cb0377
CHANGES, isso.cfg: Document gravatar size requirements
ix5 Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ Changelog for Isso
This change necessitates adjusting custom CSS files to the new names.
- Drop support for outdated Python version 3.5
(#808, l33tname)
- Fix avatar sizing, limit default gravatar images to 55px (#831, l33tname)
In case of a custom gravatar URL, the ``&s=55`` size parameter will have
to be added, see `Gravatar: Image requests`_.

.. _Gravatar: Image requests: http://en.gravatar.com/site/implement/images/

0.12.6 (2022-03-06)
-------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/configuration/server.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ gravatar

gravatar-url
Url for gravatar images. The "{}" is where the email hash will be placed.
Defaults to "https://www.gravatar.com/avatar/{}?d=identicon"
Defaults to "https://www.gravatar.com/avatar/{}?d=identicon&s=55"

latest-enabled
If True it will enable the ``/latest`` endpoint. Optional, defaults
Expand Down
1 change: 0 additions & 1 deletion isso/css/isso.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
.isso-comment > .isso-avatar {
display: block;
float: left;
width: 7%;
margin: 3px 15px 0 0;
}
.isso-comment > .isso-avatar > svg {
Expand Down
4 changes: 3 additions & 1 deletion isso/isso.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ log-file =
gravatar = false

# default url for gravatar. {} is where the hash will be placed
gravatar-url = https://www.gravatar.com/avatar/{}?d=identicon
# `s=55` results in height and width of 55px.
# for other options, see http://en.gravatar.com/site/implement/images/
gravatar-url = https://www.gravatar.com/avatar/{}?d=identicon&s=55

# enable the "/latest" endpoint, that serves comment for multiple posts (not
# needing to previously know the posts URIs)
Expand Down